fix: Support NodeJS 24 build env.#4401
Merged
Merged
Conversation
GordonSmith
force-pushed
the
NODEJS_24
branch
3 times, most recently
from
7c2b5d4 to
2d5318b
Compare
GordonSmith
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for NodeJS 24 by updating CI workflows, introducing a new type-leaks test suite, and bumping dependency versions across packages.
- Introduce
tests/type-leakssuite with Vitest configuration, tests, and documentation - Add
test-type-leaksscript and update GitHub Actions to use Node.js 24 - Bump package versions in various
package.jsonfiles
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/type-leaks/vitest.config.ts | Add Vitest configuration for the type-leaks test suite |
| tests/type-leaks/type-dependencies.spec.ts | New test to enforce declared type-only dependencies |
| tests/type-leaks/package.json | Manifest for the type-leaks test project |
| tests/type-leaks/README.md | Documentation for running and understanding the new tests |
| packages/markdown-it-plugins/package.json | Move @types/markdown-it into dependencies |
| packages/esbuild-plugins/package.json | Bump versions of esbuild, vite, and related plugins |
| packages/dgrid-shim/package.json | Update dojo-webpack-plugin to a newer patch version |
| package.json | Add test-type-leaks npm script |
| .github/workflows/update-docs.yml | Change Node.js version to 24 for docs update workflow |
| .github/workflows/release-please.yml | Change Node.js version to 24 for release workflow |
Comments suppressed due to low confidence (3)
tests/type-leaks/README.md:34
- The README instructs to use
cd tests/types, but the directory is namedtests/type-leaks. Please update the path tocd tests/type-leaks.
cd tests/types
tests/type-leaks/README.md:13
- The test implementation scans files under the
types/directory, notsrc/. Please update the documentation to reflect the actual scanned paths.
1. **TypeScript source files**: Scans all `.ts` files in each package's `src/` directory
tests/type-leaks/vitest.config.ts:5
- [nitpick] The
namefield is set totypes, which may be too generic. Consider renaming it totype-leaksto better reflect the test suite's purpose.
name: "types",
Comment on lines
+80
to
+81
| // Import declarations | ||
| if (node.type === "ImportDeclaration" && node.source?.value) { |
There was a problem hiding this comment.
[nitpick] The import extraction logic duplicates handling for value and type imports separately. Consider merging these conditions into a single block to reduce code duplication.
Suggested change
| // Import declarations | |
| if (node.type === "ImportDeclaration" && node.source?.value) { | |
| // Import declarations (value and type imports) | |
| if (node.type === "ImportDeclaration" && node.source?.value && (node.importKind === "type" || node.importKind === undefined)) { |
jeclrsg
approved these changes
Jun 26, 2025
Contributor
jeclrsg
left a comment
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith Looks correct to me. Copilot had a few nitpick comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Add support for NodeJS 24
Checklist:
Testing: